-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow boot features, print columns, and Workflow Conditions #1000
Merged
jacobweinstock
merged 24 commits into
tinkerbell:main
from
jacobweinstock:builtin-workflow-features
Oct 3, 2024
Merged
Workflow boot features, print columns, and Workflow Conditions #1000
jacobweinstock
merged 24 commits into
tinkerbell:main
from
jacobweinstock:builtin-workflow-features
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add spec field and functionality for setting the allowPXE field in hardware. Add spec field and functionality for creating a job.bmc.tinkerbell.org object to get the Hardware into a netboot state. Signed-off-by: Jacob Weinstock <[email protected]>
Use status' to make sure creation and deletion work properly. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 28.04% 30.06% +2.01%
==========================================
Files 70 71 +1
Lines 3484 3739 +255
==========================================
+ Hits 977 1124 +147
- Misses 2445 2539 +94
- Partials 62 76 +14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
related to tinkerbell/roadmap#33 |
Add tests for handleOneTimeNetboot and handleHardwareAllowPXE. Signed-off-by: Jacob Weinstock <[email protected]>
Hopefully improved the understandability of the field some. Signed-off-by: Jacob Weinstock <[email protected]>
Update rbac. Signed-off-by: Jacob Weinstock <[email protected]>
Upgrades and removed unused dep. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Pin apk packages in all Dockerfiles. Signed-off-by: Jacob Weinstock <[email protected]>
Push the boolean info to the caller so that handleHardwareAllowPXE can be simpler. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
builtin-workflow-features
branch
from
September 20, 2024 21:56
73be3cf
to
b55317e
Compare
jacobweinstock
changed the title
WIP: Builtin workflow features
new Workflow booting features
Sep 20, 2024
This allows for adding/modifying conditions without changing the Workflow spec. Signed-off-by: Jacob Weinstock <[email protected]>
Moving to using Conditions required the tests be updated. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
- Allows update existing conditions. - Remove using conditions to check state, add top level status fields for state. - Add TemplateRendering status field, printcolumn, and implementation - Add currentAction status field, printcolumn, and implementation - Move boot options code to their own file Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
changed the title
new Workflow booting features
new Workflow booting features, print columns, and Workflow Conditions
Sep 26, 2024
jacobweinstock
changed the title
new Workflow booting features, print columns, and Workflow Conditions
Workflow booting features, print columns, and Workflow Conditions
Sep 26, 2024
Make the spec and status fields for boot options the same so they are logically correlated. Change global state from WorkflowStatePreparing to WorkflowStateWaiting. This follows Kubernetes Pod container states. https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-states Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Sep 27, 2024
Return in each switch case. Make function for patching status. Reorganize where some conditions were being set. Replace !errors.IsNotFound with ctrlclient.IgnoreNotFound in order to improve readability. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
changed the title
Workflow booting features, print columns, and Workflow Conditions
Workflow boot features, print columns, and Workflow Conditions
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds fields in the Workflow spec that trigger handling of setting hardware
allowPxe
field and getting machines into a netbooting state.toggleAllowNetboot
: indicates whether the controller should toggle the field in the associated hardware for allowing PXE booting. This will be enabled before a Workflow is executed and disabled after the Workflow has completed successfully. A HardwareRef must be provided.oneTimeNetboot
: indicates whether the controller should create ajob.bmc.tinkerbell.org
object for getting the associated hardware into a netbooting state. A HardwareRef that contains a spec.bmcRef must be provided.Current Workflow spec example:
New Workflow spec example:
Adds the following columns to
kubectl get workflow
:CURRENT-ACTION
andTEMPLATE-RENDERING
.Introduces Conditions to the Workflow spec. The following are the initial conditions.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Upgrade:
Checklist:
I have: